Re: [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

From: Phil Sorber <phil(at)omniti(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq
Date: 2013-02-20 20:16:56
Message-ID: CADAkt-jRRt7-uVEekN4Nx+w1o_ckUid0s==XJjnzHie+zZHRYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 20, 2013 at 2:16 PM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> Where does this leave the PQconninfoParseParams/PQconninfodefaultsMerge
> patch? I'm not sure. Somehow I thought it would be necessary for this work,
> but it wasn't. I didn't remember that we already have PQconninfoParse()
> function, which was enough. So, what's the use case for those functions?
>

I don't think that there is an immediate case. I still think they are
useful, and would be more useful if we had some other functions that
took PQconninfoOption. But the original reason for their being has
been circumvented and I think we should just push them off to next
release commit fest and discuss them then.

> - Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-02-20 21:25:50 Re: Materialized views WIP patch
Previous Message Stephen Frost 2013-02-20 19:35:35 Re: Materialized views WIP patch