Re: [WIP] pg_ping utility

From: Phil Sorber <phil(at)omniti(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [WIP] pg_ping utility
Date: 2012-11-16 04:38:09
Message-ID: CADAkt-jAhFP1tyNjx+eiQSO5kBSKPOPfnmyF64ScLit2Crq+Fg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 15, 2012 at 10:55 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Hum, it is not really consistent to use a magic number here, particularly in
> the case where an additional state would be added in the enum PGPing. So why
> not simply return PQPING_NO_ATTEMPT when there are incorrect options or you
> show the help and exit? Looks like the best option here.

Good point. I will make that change as well.

> --
> Michael Paquier
> http://michael.otacoo.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2012-11-16 04:38:18 Re: WIP patch: add (PRE|POST)PROCESSOR options to COPY
Previous Message Simon Riggs 2012-11-16 04:37:49 Re: Do we need so many hint bits?