Re: PATCH: psql boolean display

From: Phil Sorber <phil(at)omniti(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: PATCH: psql boolean display
Date: 2012-08-20 21:31:19
Message-ID: CADAkt-heXPw3xL=M4q0ESmKhR+Xqiw3CF5e+VA9rY111Y1ZNCg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Aug 20, 2012 5:19 PM, "Phil Sorber" <phil(at)omniti(dot)com> wrote:
>
> On Aug 20, 2012 5:11 PM, "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com> wrote:
> >
> > 2012/8/20 Robert Haas <robertmhaas(at)gmail(dot)com>:
> > > On Sun, Aug 19, 2012 at 12:02 PM, Phil Sorber <phil(at)omniti(dot)com> wrote:
> > >> I am providing a patch to allow you to change the output of a boolean
> > >> value in psql much like you can do with NULL. A client requested this
> > >> feature and we thought it may appeal to someone else in the
community.
> > >>
> > >> The patch includes updated docs and a regression test. The code
> > >> changes themselves are pretty simple and straightforward.
> > >>
> > >> Example from the regression test:
> > >>
> > >> SELECT true, false;
> > >> bool | bool
> > >> ------+------
> > >> t | f
> > >> (1 row)
> > >>
> > >> \pset booltrue 'foo'
> > >> \pset boolfalse 'bar'
> > >> SELECT true, false;
> > >> bool | bool
> > >> ------+------
> > >> foo | bar
> > >> (1 row)
> > >>
> > >> \pset booltrue 't'
> > >> \pset boolfalse 'f'
> > >> SELECT true, false;
> > >> bool | bool
> > >> ------+------
> > >> t | f
> > >> (1 row)
> > >>
> > >> As always, comments welcome.
> > >
> > > Why not just do it in the SQL?
> > >
> > > SELECT CASE WHEN whatever THEN 'foo' ELSE 'bar' END AS whatever;
> >
> > I understand this motivation - although I was more happy with server
> > side solution.
> >
>
> Was a server side implementation submitted before? I can change it, but I
did it on the client side like the null display was done.

Or how about both?

>
> > Regards
> >
> > Pavel Stehule
> >
> > >
> > > --
> > > Robert Haas
> > > EnterpriseDB: http://www.enterprisedb.com
> > > The Enterprise PostgreSQL Company
> > >
> > >
> > > --
> > > Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> > > To make changes to your subscription:
> > > http://www.postgresql.org/mailpref/pgsql-hackers

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thom Brown 2012-08-20 21:54:42 Re: PATCH: psql boolean display
Previous Message Phil Sorber 2012-08-20 21:19:11 Re: PATCH: psql boolean display