From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Kevin Grittner <kgrittn(at)postgresql(dot)org>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Add infrastructure to support EphemeralNamedRelation references. |
Date: | 2017-04-06 22:03:20 |
Message-ID: | CACjxUsP8g_4yhdFS7rPd+YUz__s8_3MC059tKf-UJ__h6Wr3ig@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Thu, Apr 6, 2017 at 4:19 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> My compiler, quite justifiedly, complains:
>
> /home/andres/src/postgresql/src/backend/parser/parse_relation.c: In function ‘get_rte_attribute_is_dropped’:
> /home/andres/src/postgresql/src/backend/parser/parse_relation.c:2899:43: warning: comparison between pointer and zero character constant [-Wpointer-compare]
> (list_nth(rte->coltypes, attnum - 1) != InvalidOid);
> ^~
> /home/andres/src/postgresql/src/backend/parser/parse_relation.c:2899:7: note: did you mean to dereference the pointer?
> (list_nth(rte->coltypes, attnum - 1) != InvalidOid);
> ^
Good catch. Will push a change from list_nth() to list_nth_oid()
for the benefit of stricter compilers. While I'm at it, I'll throw
on another layer of parentheses to ensure people read that
correctly. Out of curiosity, what compiler or setting catches this?
--
Kevin Grittner
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2017-04-06 22:07:53 | Re: pgsql: Add infrastructure to support EphemeralNamedRelation references. |
Previous Message | Andres Freund | 2017-04-06 21:50:02 | pgsql: Allow avoiding tuple copy within tuplesort_gettupleslot(). |