| From: | Ali Akbar <the(dot)apaan(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Gregory Smith <gregsmithpgsql(at)gmail(dot)com> |
| Subject: | Re: Last Commitfest patches waiting review |
| Date: | 2014-10-07 02:06:40 |
| Message-ID: | CACQjQLoqzE06Ra9FZ5cmyzCPzKi94Ot0bbEmuvmqmKR_byNYRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2014-10-03 23:14 GMT+07:00 Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>:
> Fix xpath() to return namespace definitions (fixes the issue with nested
> or repeated xpath())
>
> Peter, you've done some XML stuff before; could you have a look at this
> too?
>
I am the author of the patch. I've sent Peter off-the-list review request
email as you had suggested before, but he didn't respond.
How can i help to ease the review? The last patch is re-implementation, as
per Tom Lane's findings about xmlNodeCopy's behavior if there's not enough
memory. It turns out that the reimplementation is not as simple as before
(because reimplement some of xmlNodeCopy code must be reimplemented here).
Reviewing the patch myself, i've found some code formatting problems. Will
fix and post in the patch's thread.
Regards,
--
Ali Akbar
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ali Akbar | 2014-10-07 02:24:42 | Re: [REVIEW] Re: Fix xpath() to return namespace definitions |
| Previous Message | Michael Paquier | 2014-10-07 01:35:04 | Re: Failure with make check-world for pgtypeslib/dt_test2 with HEAD on OSX |