| From: | Sameer Thakur <samthakur74(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_stat_statements: calls under-estimation propagation |
| Date: | 2013-11-18 09:54:16 |
| Message-ID: | CABzZFEsvnuYhWGWxTadunsSQod4JvpvSeX4Bj_U153qz9Ai0jw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
Please find v10 of patch attached. This patch addresses following
review comments
1. Removed errcode and used elogs for error "pg_stat_statements schema
is not supported by its binary"
2. Removed comments and other code formatting not directly relevant to
patch functionality
3. changed position of query_id in view to userid,dbid,query_id..
4 cleaned the patch some more to avoid unnecessary whitespaces, newlines.
I assume the usage of PGSS_TUP_LATEST after explanation given.
Also the mixing of PG_VERSION_NUM with query_id is ok after after
explanation given.
regards
Sameer
| Attachment | Content-Type | Size |
|---|---|---|
| pg_stat_statements-identification-v10.patch.gz | application/x-gzip | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2013-11-18 10:50:21 | Re: Sequence Access Method WIP |
| Previous Message | Andres Freund | 2013-11-18 09:48:56 | Re: Sequence Access Method WIP |