Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.

From: Gurjeet Singh <gurjeet(at)singh(dot)im>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.
Date: 2014-07-01 23:19:26
Message-ID: CABwTF4Wyp3ym+Nj-+vAnj4Go5jdoepX=P09BpgJdLMd+2g8tbw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 29, 2014 at 11:58 AM, Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> I have reviewed this patch, and think we should do what the patch
> is trying to do, but I don't think the submitted patch would
> actually work.

Just curious, why do you think it won't work. Although the discussion
is a bit old, but I'm sure I would've tested the patch before
submitting.

> I have attached a suggested patch which I think
> would work. Gurjeet, could you take a look at it?

The patch, when considered together with Tom's suggestion upthread,
looks good to me.

Best regards,
--
Gurjeet Singh http://gurjeet.singh.im/

EDB : www.EnterpriseDB.com : The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Kirkwood 2014-07-01 23:28:10 Re: Wait free LW_SHARED acquisition
Previous Message Andres Freund 2014-07-01 22:38:06 Re: Spinlocks and compiler/memory barriers