Re: PQconninfo function for libpq

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, zb <zb(at)cybertec(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: PQconninfo function for libpq
Date: 2012-12-04 12:59:09
Message-ID: CABUevEznGT6WNKrcgTpiSOTykM4DjuDKLZq4gcWXbkRgya1Qgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 3, 2012 at 3:20 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Nov 30, 2012 at 1:02 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> In the interest of moving things along, I'll remove these for now at
>> least, and commit the rest of the patch, so we can keep working on the
>> basebacku part of things.
>
> I see you committed this - does this possibly provide infrastructure
> that could be used to lift the restriction imposed by the following
> commit?
>
> commit fe21fcaf8d91a71c15ff25276f9fa81e0cd1dba9
> Author: Bruce Momjian <bruce(at)momjian(dot)us>
> Date: Wed Aug 15 19:04:52 2012 -0400
>
> In psql, if the is no connection object, e.g. due to a server crash,
> require all parameters for \c, rather than using the defaults, which
> might be wrong.
>
> Because personally, I find the new behavior no end of annoying.

It certainly sounds like it could do that. Though it might be useful
to actually add a connection funciton to libpq that takes such an
array of options directly - AFAICS, right now you'd have to
deconstruct the return value into a string, and then pass it into a
connection function that immediately parses it right back out as
conninfooptions.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ibrar Ahmed 2012-12-04 13:04:04 Re: Review: create extension default_full_version
Previous Message Pavan Deolasee 2012-12-04 12:31:52 Re: Hot Standby conflict resolution handling