| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Mika Eloranta <mel(at)ohmu(dot)fi> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pg_basebackup: progress report max once per second |
| Date: | 2014-01-09 18:05:02 |
| Message-ID: | CABUevEyW2aYwD+oxDbuMusPOAGHwXM9Sidm+w9WiAG6hvn8qJQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 14, 2013 at 10:27 AM, Mika Eloranta <mel(at)ohmu(dot)fi> wrote:
> On 13 Nov 2013, at 20:51, Mika Eloranta <mel(at)ohmu(dot)fi> wrote:
>
> > Prevent excessive progress reporting that can grow to gigabytes
> > of output with large databases.
>
> Same patch as an attachment.
>
Would it not make more sense to instead store the last number printed, and
only print it if the percentage has changed? AIUI with this patch we still
print the same thing on top of itself if it takes >1 second to get 1%
further.
(Except for verbose mode - but if you're asking for verbose mode, you are
*asking* to get lots of output)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-01-09 18:05:06 | Re: Turning off HOT/Cleanup sometimes |
| Previous Message | Tom Lane | 2014-01-09 18:03:08 | Re: integrate pg_upgrade analyze_new_cluster.sh into vacuumdb |