From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically. |
Date: | 2013-07-19 12:51:17 |
Message-ID: | CABUevExa47n1LM0PDXfVJe=+HozN9uvhCQUphEztykQKj+uxPQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Jul 19, 2013 at 1:23 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jul 19, 2013 at 7:24 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> The changes here make it impossible to write a bgworker which properly
>> works in 9.3 and 9.4. Was that intended? If so, the commit message
>> should mention the compatibility break...
>
> Yeah, sorry, I probably should have mentioned that. The structure
> needs to be fixed size for us to store it in shared memory.
>
>> If it was intended I propose changing the signature for 9.3 as
>> well. There's just no point in releasing 9.3 when we already know which
>> trivial but breaking change will be required for 9.4
>
> I think that would be a good idea. And I'd also propose getting rid
> of bgw_sighup and bgw_sigterm in both branches, while we're at it.
> AFAICT, they don't add any functionality, and they're basically
> unusable for dynamically started background workers. Probably better
> not to get people to used to using them.
+1. Much better to take that pain now, before we have made a production release.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2013-07-19 12:52:50 | Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically. |
Previous Message | Robert Haas | 2013-07-19 12:23:25 | Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically. |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2013-07-19 12:52:50 | Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically. |
Previous Message | Robert Haas | 2013-07-19 12:29:17 | Re: Eliminating PD_ALL_VISIBLE, take 2 |