Re: Using pg_upgrade on log-shipping standby servers

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Using pg_upgrade on log-shipping standby servers
Date: 2012-07-10 17:06:39
Message-ID: CABUevExNkFCr0bn5=_2WP1gMomeBEsuf0okUCva+aiv30e0uNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 10, 2012 at 6:59 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Tue, Jul 10, 2012 at 06:29:24PM +0200, Magnus Hagander wrote:
>> > Testing maybe? I feel we have just avoided saying what you can and
>> > can't do with the standbys and pg_upgrade, so I think we have to state
>> > something. If we just want to say "recreate", let's say that.
>>
>> Well, the bottom line is we can'd do *anything* with a standby with pg_upgrade.
>>
>> Once you've promoted it, it is no longer a standby, and now you can
>> use pg_upgrade.
>>
>> >> And I think the sentence about running rsync is extremely vague - run
>> >> rsync where and how? What are you actually trying to suggest people
>> >> do?
>> >
>> > Updated docs attached.
>>
>> I suggest just removing the rsync part completely. You're basically
>> saying "you ca nset up a new standby after you're done", which is kind
>> of obvious anyway. And if you're going to use rsync fromthe master to
>> make a new standby, there's no point in running pg_upgrade on the new
>> standby in the first place.
>
> I went the other direction and just said you can't upgrade a standby (as
> a standby), and to just use rsync --- patch attached.

Reads much better now. I'd say "use rsync to rebuild the standbys",
but that's more nitpicking :) (And maybe "the simplest way" rather
than "the simplest case"? But i'll leave that to someone who has
english as their first language)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2012-07-10 17:27:27 Re: Using pg_upgrade on log-shipping standby servers
Previous Message Fujii Masao 2012-07-10 17:03:06 Re: several problems in pg_receivexlog