| From: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: XLByte* usage |
| Date: | 2012-12-17 09:04:41 |
| Message-ID: | CABOikdNDCzyXE=oS=gThHr7A_YcSeyYm9TGN46WSSp3PnEp07w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 17, 2012 at 2:00 PM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> On 16.12.2012 16:16, Andres Freund wrote:
>>
>> Now that XLRecPtr's are plain 64bit integers what are we supposed to use
>> in code comparing and manipulating them? There already is plenty example
>> of both, but I would like new code to go into one direction not two...
>>
>> I personally find direct comparisons/manipulations far easier to read
>> than the XLByte* equivalents.
>
>
> I've still used XLByte* macros, but I agree that plain < = > are easier to
> read. +1 for using < = > in new code.
>
Do we ever see us changing this from 64-bit integers to something else
? If so, a macro would be much better.
Thanks,
Pavan
--
Pavan Deolasee
http://www.linkedin.com/in/pavandeolasee
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Rijkers | 2012-12-17 09:06:18 | Re: is possible enforce \timing on from command line |
| Previous Message | classical_89 | 2012-12-17 08:59:46 | Re: is possible enforce \timing on from command line |