| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Support for REINDEX CONCURRENTLY |
| Date: | 2013-07-02 20:43:53 |
| Message-ID: | CAB7nPqTgA_8VDf9WQd-+NTu3OUf549Qb+0Sxw2vw-_fCZ_9=EA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 3, 2013 at 5:22 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> Why did you remove the check of indisvalid from the --binary-upgrade SQL?
> Without this check, if there is the invalid toast index, more than one rows are
> returned and ExecuteSqlQueryForSingleRow() would cause the error.
>
> + foreach(lc, indexlist)
> + *toastidxs[i++] = index_open(lfirst_oid(lc), lock);
>
> *toastidxs[i++] should be (*toastidxs)[i++]. Otherwise, segmentation fault can
> happen.
>
> For now I've not found any other big problem except the above.
OK cool, updated version attached. If you guys think that the attached
version is fine (only the reltoasyidxid removal part), perhaps it
would be worth committing it as Robert also committed the MVCC catalog
patch today. So we would be able to focus on the core feature asap
with the 2nd patch, and the removal of AccessExclusiveLock at swap
step.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20130704_1_remove_reltoastidxid_v16.patch | application/octet-stream | 47.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2013-07-02 20:51:58 | Re: Support for REINDEX CONCURRENTLY |
| Previous Message | Robert Haas | 2013-07-02 20:29:56 | Re: preserving forensic information when we freeze |