Re: [patch] reorder tablespaces in basebackup tar stream for backup_label

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Bernd Helmle <mailings(at)oopsware(dot)de>
Cc: Michael Banck <michael(dot)banck(at)credativ(dot)de>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [patch] reorder tablespaces in basebackup tar stream for backup_label
Date: 2017-03-04 07:20:43
Message-ID: CAB7nPqTdbR7OKBBnWAZ6qB7821foc_X1_s8bV7BWrJ73OrAv-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 4, 2017 at 1:13 AM, Bernd Helmle <mailings(at)oopsware(dot)de> wrote:
> Ah right, i assumed there must be something, otherwise the comment
> won't be there ;)
>
> We could special case that part to distinguish fetch/stream mode, but i
> fear that leads to more confusion than it wants to fix. The other
> option of a separate tar file looks awkward from a usability point of
> view.

It is possible as well to group the WAL files in a different tarball
than the main directory and put that at the tail of the list for the
fetch mode, while the main directory gets at the head. That would
break things for existing users by the way, and just being able to
look at the LSN start location before receiving the tar bytes of the
backup does not seem enough to justify such a breakage.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-03-04 07:24:12 Re: Disallowing multiple queries per PQexec()
Previous Message Robert Haas 2017-03-04 07:19:55 Re: UPDATE of partition key