Re: Add shutdown_at_recovery_target option to recovery.conf

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alex Shulgin <ash(at)commandprompt(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add shutdown_at_recovery_target option to recovery.conf
Date: 2014-12-05 16:02:10
Message-ID: CAB7nPqTQJ5BuKn=sDAfxzDqcCfq8sVcic894jR-Vp78nTUHABA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 6, 2014 at 12:49 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Thu, Dec 4, 2014 at 8:45 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> >> Here is patch which renames action_at_recovery_target to
> >> recovery_target_action everywhere.
> > Thanks, Looks good to me.
> >
> > A couple of things that would be good to document as well in
> > recovery-config.sgml:
> > - the fact that pause_at_recovery_target is deprecated.
>
> Why not just remove it altogether? I don't think the
> backward-compatibility break is enough to get excited about, or to
> justify the annoyance of carrying an extra parameter that does (part
> of) the same thing.
>
At least we won't forget removing in the future something that has been
marked as deprecated for years. So +1 here for a simple removal, and a
mention in the future release notes.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2014-12-05 16:04:59 Re: Yet another abort-early plan disaster on 9.3
Previous Message Robert Haas 2014-12-05 15:59:54 Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}