| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical replication and PANIC during shutdown checkpoint in publisher |
| Date: | 2017-06-01 23:38:51 |
| Message-ID: | CAB7nPqTMDXY11qTGdg7W7ZAx52ghFNkVVSGumBTJQPF+Yy7zwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 2, 2017 at 7:05 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I'm a unhappy how this is reusing SIGINT for WalSndLastCycleHandler.
> Normally INT is used cancel interrupts, and since walsender is now also
> working as a normal backend, this overlap is bad. Even for plain
> walsender backend this seems bad, because now non-superusers replication
> users will terminate replication connections when they do
> pg_cancel_backend(). For replication=dbname users it's especially bad
> because there can be completely legitimate uses of pg_cancel_backend().
Signals for WAL senders are set in WalSndSignals() which uses SIG_IGN
for SIGINT now in ~9.6, and StatementCancelHandler does not get set up
for a non-am_walsender backend. Am I missing something?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2017-06-01 23:47:42 | Re: Perfomance bug in v10 |
| Previous Message | Mark Kirkwood | 2017-06-01 22:46:22 | Re: logical replication - still unstable after all these months |