| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, furuyao(at)pm(dot)nttdata(dot)co(dot)jp, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivexlog and replication slots |
| Date: | 2014-10-03 01:30:19 |
| Message-ID: | CAB7nPqTJnuA7p+NxPMoKP0Ym5Wgbot7Zj5g=uXQxD5QBBAtr5g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 2, 2014 at 12:44 AM, Andres Freund <andres(at)2ndquadrant(dot)com>
wrote:
> I pushed the first part.
>
Thanks. Attached is a rebased version of patch 2, implementing the actual
feature. One thing I noticed with more testing is that if --create is used
and that the destination folder does not exist, pg_receivexlog was creating
the slot, and left with an error. This does not look user-friendly so I
changed the logic a bit to check for the destination folder before creating
any slot. This results in a bit of refactoring, but this way behavior is
more intuitive.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20141003_pg_receivexlog_slots.patch | text/x-diff | 7.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2014-10-03 02:03:10 | GiST splitting on empty pages |
| Previous Message | Robert Haas | 2014-10-03 01:18:14 | Re: TAP test breakage on MacOS X |