Missing file versions for a bunch of dll/exe files in Windows builds

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: pgsql-bugs(at)postgresql(dot)org
Subject: Missing file versions for a bunch of dll/exe files in Windows builds
Date: 2014-04-24 05:54:15
Message-ID: CAB7nPqSv-shp7rReh1esKbeENOjsK0RxQ9h0NVGhp+oeR+FLLg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi all,

A colleague of mine pointed out that the file version is missing in a
couple of dll and exe files when building on windows using the
community scripts in src/tools/msvc. After having a closer look, I
noticed that a *lot* of files are missing the shot:
- all the exe/dll in contrib/
- dll of PL languages (perl, python, tcl, pgsql)
- libpqwalreceiver, snowball
- ecpg stuff
- regression and isolation test stuff
- conversion_procs thingies
Having a version number associated to a build is important for all
companies creating builds of Postgres on Windows, so it would be good
to have the patch attached applied and back-patched.

Regards,
--
Michael

Attachment Content-Type Size
20140424_win_rcfiles.patch text/plain 7.5 KB

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message tcoq 2014-04-24 06:37:34 LOG: incomplete message from client
Previous Message Tom Lane 2014-04-24 01:30:39 Re: BUG #10122: proargtypes and proallargtypes are inconsistent for pg_identify_object