Re: Including replication slot data in base backups

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Including replication slot data in base backups
Date: 2014-04-07 07:04:09
Message-ID: CAB7nPqS_Ha2hg3Y=HNvnvGYRtS7bQ_4Rs0hp+bKtqT+3Fx9b9w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 4, 2014 at 9:57 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> For 9.4, clearly yes, this would change the semantic of recovery and
> this is not something wise to do at the end of a development cycle.
> For 9.5 though, this is a different story. It clearly depends on if
> this is though as useful enough to change how recovery fetches WAL
> files (in this case by scanning existing repslots). There are other
> things to consider as well like for example: do we reset the
> restart_lsn of a repslot if needed WAL files are not here anymore or
> abort recovery? I haven't worked much with repslots though...
Coming back to that, I am still wondering if for the time being it
would not be better to add in pg_basebackup documentation that
replication slot information is not added in a backup, per se the
patch attached.
Regards,
--
Michael

Attachment Content-Type Size
20140407_basebackup_slot_doc.patch text/plain 660 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2014-04-07 07:18:12 Re: polymorphic SQL functions has a problem with domains
Previous Message Ian Barwick 2014-04-07 07:00:55 Re: Autonomous Transaction (WIP)