On Sun, Oct 12, 2014 at 7:09 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Noah Misch (noah(at)leadboat(dot)com) wrote:
>> On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote:
>> > I personally wouldn't object plaing a #include for the splitof file into
>> > builtin.h to address backward compat concerns. Would imo still be an
>> > improvement.
>>
>> Agreed. If the patch preserved compatibility by having builtins.h include
>> quote.h, I would not object.
>
> That seems reasonable to me also- though I'd caveat it as "for now" and
> make sure to make a note of the reason it's included in the comments...
This seems like a consensus. I updated the patch with the following things:
- Declaration of quote.h in builtins.h, with a comment on top of builtins.h.
- Removal of declaration of builtins.h where it is not necessary
anymore, replaced by quote.h. I thought there would be more places,
but a lot of files still depend on the cstring and format_type.
Perhaps this could be as well separated, keeping only the function
declarations of the type Datum foo(PG_FUNCTION_ARGS) in builtins.h...
Regards,
--
Michael