recovery_min_apply_delay with a negative value

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: recovery_min_apply_delay with a negative value
Date: 2014-12-28 14:31:15
Message-ID: CAB7nPqS6yQEFC1=4yR_d8yQ4rEw4+ZBhjB4nvHC_av2wLnayVg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

While reviewing another patch, I have noticed that recovery_min_apply_delay
can have a negative value. And the funny part is that we actually attempt
to apply a delay even in this case, per se this condition
recoveryApplyDelay(at)xlog(dot)c:
/* nothing to do if no delay configured */
if (recovery_min_apply_delay == 0)
return false;
Shouldn't we simply leave if recovery_min_apply_delay is lower 0, and not
only equal to 0?
Regards,
--
Michael

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-12-28 15:15:03 Re: Patch: add recovery_timeout option to control timeout of restore_command nonzero status code
Previous Message Craig Ringer 2014-12-28 14:21:15 Re: attaching a process in eclipse