| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com> |
| Subject: | Re: tracking commit timestamps |
| Date: | 2014-11-04 23:57:07 |
| Message-ID: | CAB7nPqS+T+-y2t-p88pwO3DG5-QJ9L_9k0yq5qt01ia0QCJc9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
On Tue, Nov 4, 2014 at 10:01 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
> Michael Paquier wrote:
>
> > I'm still on a -1 for that. You mentioned that there is perhaps no reason
> > to delay a decision on this matter, but IMO there is no reason to rush
> > either in doing something we may regret. And I am not the only one on
> this
> > thread expressing concern about this extra data thingy.
> >
> > If this extra data field is going to be used to identify from which node
> a
> > commit comes from, then it is another feature than what is written on the
> > subject of this thread. In this case let's discuss it in the thread
> > dedicated to replication identifiers, or come up with an extra patch once
> > the feature for commit timestamps is done.
>
> Introducing the extra data field in a later patch would mean an on-disk
> representation change, i.e. pg_upgrade trouble.
Then why especially 4 bytes for the extra field? Why not 8 or 16?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-11-04 23:59:00 | Re: to_char_at_timezone()? |
| Previous Message | Marko Tiikkaja | 2014-11-04 23:48:57 | to_char_at_timezone()? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-11-05 01:13:47 | Re: tracking commit timestamps |
| Previous Message | Petr Jelinek | 2014-11-04 21:31:55 | Re: tracking commit timestamps |