Re: [PATCH] Support for pg_stat_archiver view

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Gabriele Bartolini <gabriele(dot)bartolini(at)2ndquadrant(dot)it>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Satoshi Nagayasu <snaga(at)uptime(dot)jp>
Subject: Re: [PATCH] Support for pg_stat_archiver view
Date: 2014-01-29 03:35:26
Message-ID: CAB7nPqRz42LsC9X-u_iXVF-A1TE5WEBZrQk4+_3LNKTQw=-PNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 29, 2014 at 10:55 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Jan 29, 2014 at 3:07 AM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
>>
>> Anybody knows about this patch?
>> http://www.postgresql.org/message-id/508DFEC9.4020102@uptime.jp
>
> Though I'm not sure whether Nagayasu is still working on that patch,
> it's worth thinking to introduce that together with pg_stat_archiver.
This patch uses globalStats to implement the new stat fields for
walwriter, I think that we should use a different structure for
clarity and to be in-line with what is done now with the archiver
part.

Btw, I agree that renaming the globalStats part to something more
appropriate related to bgwriter is a sane target for this CF, but
isn't it too late to late to consider this walwriter patch for this
release? It introduces a new feature as it tracks xlog dirty writes
and CF is already half way.
Regards,
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-01-29 03:35:30 Re: Suspicion of a compiler bug in clang: using ternary operator in ereport()
Previous Message Fujii Masao 2014-01-29 01:55:38 Re: [PATCH] Support for pg_stat_archiver view