Re: Dump pageinspect to 1.2: page_header with pg_lsn datatype

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Dump pageinspect to 1.2: page_header with pg_lsn datatype
Date: 2014-02-24 08:53:31
Message-ID: CAB7nPqRThQHOxE53kavMfQy5iBoNspEd=TDvrsRX84asHA0K=Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 23, 2014 at 6:09 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>wrote:

> Michael Paquier escribió:
> > Hi all,
> >
> > Please find attached a patch to dump pageinspect to 1.2. This simply
> > changes page_header to use the new internal datatype pg_lsn instead of
> text.
>
> Uhm. Does this crash if you pg_upgrade a server that has 1.1 installed?
>
Oops yes you're right., it is obviously broken. Just re-thinking about
that, dumping this module just to change an argument type does not seem to
be worth the code complication. Thoughts?
Regards,
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-02-24 09:15:40 Re: Dump pageinspect to 1.2: page_header with pg_lsn datatype
Previous Message Mohsen SM 2014-02-24 07:11:30 varchar_transform