Re: should we add a XLogRecPtr/LSN SQL type?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: should we add a XLogRecPtr/LSN SQL type?
Date: 2014-02-25 00:29:44
Message-ID: CAB7nPqRQp18-tkgmijyuEons3Vk8Txd3BYjrL_NUrxMqCQhEdw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 25, 2014 at 12:41 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Wed, Feb 19, 2014 at 8:27 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> > On Thu, Feb 20, 2014 at 8:55 AM, Andres Freund <andres(at)2ndquadrant(dot)com>
> wrote:
> >> On 2014-02-19 12:47:40 -0500, Robert Haas wrote:
> >>> On Wed, Feb 5, 2014 at 9:26 PM, Michael Paquier
> >>> <michael(dot)paquier(at)gmail(dot)com> wrote:
> >>> >> Yes, that's a good precedent in multiple ways.
> >>> > Here are updated patches to use pg_lsn instead of pglsn...
> >>>
> >>> OK, so I think this stuff is all committed now, with assorted changes.
> >>> Thanks for your work on this.
> >>
> >> cool, thanks you two.
> >>
> >> I wonder if pg_stat_replication shouldn't be updated to use it as well?
> >> SELECT * FROM pg_attribute WHERE attname ~ '(location|lsn)'; only shows
> >> that as names that are possible candidates for conversion.
> > I was sure to have forgotten some views or functions in the previous
> > patch... Please find attached a patch making pg_stat_replication use
> > pg_lsn instead of the existing text fields.
> > Regards,
>
> Committed. Do we want to do anything about pageinspect?
>
Thanks. We're dealing with that on another thread, I'll send an updated
patch there.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2014-02-25 01:02:25 Re: Dump pageinspect to 1.2: page_header with pg_lsn datatype
Previous Message Haribabu Kommi 2014-02-25 00:13:31 Re: contrib/cache_scan (Re: What's needed for cache-only table scan?)