| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | MauMau <maumau307(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: option -T in pg_basebackup doesn't work on windows |
| Date: | 2014-08-14 01:48:14 |
| Message-ID: | CAB7nPqRN3-CXLEPqk5CRMvwYQuXCvhxsDpt45e5AMhafsb-9fQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 14, 2014 at 12:50 AM, MauMau <maumau307(at)gmail(dot)com> wrote:
> The code change appears correct, but the patch application failed against
> the latest source code. I don't know why. Could you confirm this?
>
> patching file src/bin/pg_basebackup/pg_basebackup.c
> Hunk #1 FAILED at 1119.
> 1 out of 1 hunk FAILED -- saving rejects to file
> src/bin/pg_basebackup/pg_basebackup.c.rej
This conflict is caused by f25e0bf.
> On the following line, I think %d must be %u, because Oid is an unsigned
> integer.
> char *linkloc = psprintf("%s/pg_tblspc/%d", basedir, oid);
That's correct.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-08-14 01:51:39 | Re: replication commands and log_statements |
| Previous Message | Andrew Dunstan | 2014-08-14 01:47:15 | Re: jsonb format is pessimal for toast compression |