Re: Add regression tests for COLLATE

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robins Tharakan <tharakan(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add regression tests for COLLATE
Date: 2013-04-12 03:58:14
Message-ID: CAB7nPqQuDd1bZxER=46o09cjo9W0CZsyhCHjkM1PkxQ83903dA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 11, 2013 at 4:14 PM, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:

> Hi,
>
> Please find attached a patch to take 'make check' code-coverage of COLLATE
> (/src/backend/commands/collationcmds) from 0% to 96%.
>
> Any feedback is more than welcome. Also posting this to Commitfest-next.
>
Just by having a quick look at the patch, using object names of the type cX
is too generic even if the tests are done in a private schema. Why not
using a name like collate_obj_X or similar?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2013-04-12 04:02:49 (auto)vacuum truncate exclusive lock
Previous Message Kevin Grittner 2013-04-12 03:21:42 Re: (auto)vacuum truncate exclusive lock