| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG: *FF WALs under 9.2 (WAS: .ready files appearing on slaves) |
| Date: | 2014-10-23 14:19:37 |
| Message-ID: | CAB7nPqQr2qUpL+yCYgbST4_5ZwAPjiLer-K-bngJa=m5=nxOvA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 23, 2014 at 10:16 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com
> wrote:
> On Thu, Oct 23, 2014 at 1:45 PM, Heikki Linnakangas <
> hlinnakangas(at)vmware(dot)com> wrote:
> That's not right. Should check *after* the write if the segment was
> completed, and close it if so. Like the attached.
>
> Just tested this patch with the combo pg_switch_xlog() + stop/immediate
> and the apparition of the .ready files is not fixed.
>
Btw, I think that we should pass walEnd to XLogWalRcvWrite and add an
additional check based on that after the write() loop calls to enforce the
segment to be switched to .done.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2014-10-23 14:23:43 | Re: idea: allow AS label inside ROW constructor |
| Previous Message | Michael Paquier | 2014-10-23 14:00:00 | Typo fixes for pg_recvlogical documentation |