Re: [PATCH] Negative Transition Aggregate Functions (WIP)

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Date: 2013-12-25 13:49:40
Message-ID: CAApHDvr4gLTEtYmYBid1nOFn3jHcPziHMa+6nMNe-nW--9k=tQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 22, 2013 at 2:42 AM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:

> On Sun, Dec 22, 2013 at 1:01 AM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>
>> On Sat, December 21, 2013 12:52, David Rowley wrote:
>> > On Sun, Dec 22, 2013 at 12:49 AM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>> >
>> >> On Sat, December 21, 2013 12:38, David Rowley wrote:
>> >> > [ inverse_transition_functions_v1.2.patch.gz ]
>> >> > Please find attached an updated patch which should remove the
>> duplicate
>> >> OID
>> >> > problem you saw.
>> >>
>> >> That fixes it, thanks
>> >>
>> >> There is 1 of 141 failed tests:
>> >>
>> >> window ... FAILED
>> >>
>> >>
>> > That's strange, it passes here.
>> >
>> > Would you be able to send me the regression diff file?
>> >
>>
>> attached...
>>
>
> Thanks
>
> This was just down to some missing trailing white space on the expected
> results. I've fixed these up and attached another patch.
>
>
I've attached an updated patch which is re-merged to current head.

I've also done a bit more work to the patch:
Added inverse transition functions for all the stddev() type aggregates for
all int types.
Added inverse transition function for SUM with bigint
Added pg_dump support.

I've yet to do SUM or AVG for numeric types due to some concern with having
more digits after the decimal point after inverse transitions take place.

Regards

David Rowley

Regards
>
> David Rowley
>
>

Attachment Content-Type Size
inverse_transition_functions_v1.5.patch.gz application/x-gzip 18.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-12-25 14:25:51 Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE
Previous Message Joel Jacobson 2013-12-25 12:42:08 [BUGFIX] Typos when using the memcmp() function.