| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] Regression tests in windows ignore white space |
| Date: | 2013-12-26 09:32:06 |
| Message-ID: | CAApHDvpwUowbD9dv6qhzm7jreXz=o4Cimb865uPBVySYG_BsqQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
In the following thread I discovered that my new regression tests worked
perfectly on windows, but when they were run on linux they failed.
After looking at pg_regress to see which options it passes to diff I
discovered that it passes -w on windows to ignore ALL white space.
The attached simple patch changes this so that it only ignores carriage
returns. It does this by passing --strip-trailing-cr to diff instead of -w.
This should help us few developers who use windows to get our white space
correct in out expected results so that the tests also pass on non windows
platforms.
Regards
David Rowley
| Attachment | Content-Type | Size |
|---|---|---|
| pg_regress_win32_diff_options.patch | application/octet-stream | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2013-12-26 12:36:49 | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |
| Previous Message | Peter Geoghegan | 2013-12-25 23:27:36 | Re: INSERT...ON DUPLICATE KEY LOCK FOR UPDATE |