Re: [PATCH] Negative Transition Aggregate Functions (WIP)

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Date: 2013-12-21 11:12:54
Message-ID: CAApHDvpMpOfyGn3f7a0HYLU4V9XOXZaagFjQiQfOcbzHV5Ffvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 21, 2013 at 11:47 PM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:

> On Sat, December 21, 2013 10:53, David Rowley wrote:
>
> > [inverse_transition_functions_v1.1.patch.gz ]
>
> Hi,
>
> I know, $subject says "WIP", but I assumed it's supposed to compile, so I
> tried to get this to run on linux (Centos 5.0).
> gcc 4.8.2,
> with
>

<snip>

> cd ../../../src/include/catalog && '/home/aardvark/perl-5.19/bin/perl'
> ./duplicate_oids
> 1220
> 1221
> 1800
> 1801
> 1970
> 1971
>

Thanks for the report. It seems the windows build does not check for
duplicate OIDs and the linux one does.
I'll just need to change the Oids of the new functions I've added, only it
seems the unused_oids perl script does not like windows.

I'll try to get you a working patch shortly.

Regards

David Rowley

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2013-12-21 11:38:26 Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Previous Message Erik Rijkers 2013-12-21 10:47:20 Re: [PATCH] Negative Transition Aggregate Functions (WIP)