Re: [PATCH] Negative Transition Aggregate Functions (WIP)

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Date: 2013-12-21 09:53:36
Message-ID: CAApHDvo6x_qHQcOF4DMm-3A1gb8Rx-=fZRyMPcg3U02=UcRGiA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 17, 2013 at 10:51 PM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:

> On Mon, Dec 16, 2013 at 9:36 PM, Hannu Krosing <hannu(at)2ndquadrant(dot)com>wrote:
>
>> On 12/16/2013 08:39 AM, David Rowley wrote:
>>
>>
>> Any other ideas or +1's for any of the existing ones?
>>
>> +1, inverse good :)
>>
>>
> In the attached patch I've renamed negative to inverse. I've also disabled
> the inverse functions when an expression in an aggregate contains a
> volatile function.
>
>
I've attached an updated patch in which I've done some more work to the
documents and also added some more sanity checking around CREATE AGGREGATE.
The previous patch allowed CREATE AGGREGATE to accept a transition function
which was strict and an inverse transition function which was not, or vise
versa.

I've also added a bunch of regression tests around create aggregate which
were missing in the previous patch.

Regards

David Rowley

Attachment Content-Type Size
inverse_transition_functions_v1.1.patch.gz application/x-gzip 15.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2013-12-21 10:47:20 Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Previous Message Andres Freund 2013-12-21 09:45:59 Re: shared memory message queues