Re: Millisecond-precision connect_timeout for libpq

From: Dmitriy Igrishin <dmitigr(at)gmail(dot)com>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: ivan babrou <ibobrik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Millisecond-precision connect_timeout for libpq
Date: 2013-07-09 15:17:34
Message-ID: CAAfz9KNUhnn8m8aE3u+Sv6==B70kv4916mqXda6F1Ej2rP9aTQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2013/7/9 Merlin Moncure <mmoncure(at)gmail(dot)com>

> On Fri, Jul 5, 2013 at 12:28 PM, ivan babrou <ibobrik(at)gmail(dot)com> wrote:
> > Hi, guys! I made a quick patch to support floating number in
> > connect_timeout param for libpq. This will treat floating number as
> > seconds so this is backwards-compatible. I don't usually write in C,
> > so there may be mistakes. Could you review it and give me some
> > feedback?
>
> First thing that jumps into my head: why not use asynchronous
> connection (PQconnectStart, etc) and code the timeout on top of that?
>
+1.

>
> merlin
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

--
// Dmitriy.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2013-07-09 15:24:42 robots.txt on git.postgresql.org
Previous Message Sawada Masahiko 2013-07-09 14:45:57 Re: Patch for fail-back without fresh backup