Re: NOT Null constraint on foreign table not working

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Rushabh Lathia <rushabh(dot)lathia(at)enterprisedb(dot)com>
Subject: Re: NOT Null constraint on foreign table not working
Date: 2014-01-21 04:25:30
Message-ID: CAA4eK1LYH8zb75zgCw=fvo_dYC8Tx3A2Nz8DBwm9Cu1H3eSbYA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 21, 2014 at 9:32 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
>> On Mon, Jan 20, 2014 at 8:52 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> There has been a great deal of debate about what constraints on foreign
>>> tables ought to mean.
>
>> What is the reason for keeping DEFAULT behaviour different than
>> constraints. Right now the behaviour for DEFAULT is if it is
>> defined on foreign table, then it will use that even if original table has
>> different or no default value?
>
> If you look back to the original thread about the writable-foreign-tables
> patch, we expended a lot of sweat on that point too. The ideal thing IMO
> would have been to allow the remote end's default specification to control
> what happens, but we found enough difficulties with that that we ended up
> punting and allowing the default expression to be evaluated locally.
> I'm not terribly satisfied with that result, but that's where we are.

okay, I think we can specify more clearly in documentation of Foreign Table
as right now it is bit difficult to get the right behaviour by reading
documentation. Another thing could be to return Syntax Error like it does
for other constraints like CKECK.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2014-01-21 04:54:51 Re: contrib/cache_scan (Re: What's needed for cache-only table scan?)
Previous Message KaiGai Kohei 2014-01-21 04:23:02 Re: dynamic shared memory and locks