Re: pg_basebackup vs. Windows and tablespaces

On Tue, Dec 16, 2014 at 10:11 PM, Heikki Linnakangas <
hlinnakangas(at)vmware(dot)com> wrote:
>
> On 12/16/2014 06:30 PM, Andrew Dunstan wrote:
>>
>> I'm not clear why human readability is the major criterion here. As for
>> that, it will be quite difficult for a human to distinguish a name with
>> a space at the end from one without. I really think a simple encoding
>> scheme would be much the best.

Yeah that could work, but we need the special encoding mainly for newline,
other's would work with current patch. However it might be worth to do
it for all kind of spaces. Currently it just reads the line upto newline
using
fscanf, but if we use special encoding, we might need to read the file
character by character and check for newline without backslash(or other
special encoding character); do you have something like that in mind?

Another thing is that we need to take care that we encode/decode link
path for tar format, as plain format might already be working.

>
>
> Agreed. Besides, this:
>
> 16387 E:\\Program\ Files\\PostgreSQL\\tbs
>
> is almost as human-readable as this:
>
> 16387 E:\Program Files\PostgreSQL\tbs
>

Yeah, that looks okay, but if there are multiple spaces like below,
then it might be slightly inconvenient.

16422 E:\WorkSpace\PostgreSQL\master\tbs 2 3

16422 E:\\WorkSpace\\PostgreSQL\\master\tbs\ \ \ \ \ \ \ \ \ \ \ \
\ \ 2\ \ \ \ \ \ \ \ \ \ \ \ \ \ \ 3

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com