From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: a fast bloat measurement tool (was Re: Measuring relation free space) |
Date: | 2015-04-24 01:52:27 |
Message-ID: | CAA4eK1KVLcFhiQ+HOVhk8gMwaHnLzQHOXW3T98WtXOkiQJ=bGA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 22, 2015 at 6:33 PM, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
wrote:
>
> At 2015-04-18 12:28:36 +0530, amit(dot)kapila16(at)gmail(dot)com wrote:
> >
> > I think you have missed to address the below point:
> >
> > >> 4) prefetch
>
> Updated patch attached, as well as the diff against the earlier version
> just to make it easier to see the exact change I made (which is to copy
> the skip logic from lazy_scan_heap, as you suggested).
>
Few minor issues:
1.
warning on windows
\pgstatbloat.c(193): warning C4715: 'pgstatbloat' : not all control paths
return a value
2.
Failed to install pgstattuple--1.3.sql
You have to name sql file as pgstattuple--1.3.sql rather
than pgstattuple--1.2.sql
Other than above 2 points, patch looks good to me.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Sawada Masahiko | 2015-04-24 02:21:18 | Re: Freeze avoidance of very large table. |
Previous Message | Tom Lane | 2015-04-24 01:28:52 | Re: adding more information about process(es) cpu and memory usage |