From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
Cc: | Marti Raudsepp <marti(at)juffo(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Golub <pavel(at)gf(dot)microolap(dot)com>, Pavel Golub <pavel(at)microolap(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pavel Stěhule <pavel(dot)stehule(at)gmail(dot)com> |
Subject: | Re: Fwd: Proposal: variant of regclass |
Date: | 2014-04-02 05:41:04 |
Message-ID: | CAA4eK1KSppcveg2mY08vbtyT8Ws0de3BRffv2kwZJsAkxpZzHQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 31, 2014 at 7:08 PM, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> Hi Amit Kapila,
>
> Thank you for your reviewing. I updated the patch to v5.
I have checked the latest version and found few minor improvements that
are required:
1.
! if (!missing_ok)
! ereport(ERROR,
! (errcode(ERRCODE_UNDEFINED_OBJECT),
! errmsg("type \"%s\" does not exist",
! TypeNameToString(typeName)),
! parser_errposition(NULL, typeName->location)));
pfree(buf.data); seems to be missing in error cases.
Do you see any problem if we call it before calling LookupTypeName()
instead of calling at multiple places?
2.
+ raising an error. In addition, neither <function>to_regproc</function> nor
+ <function>to_regoper</function> doesn't raise an error when more than one
+ object are found.
No need to use word *doesn't* in above sentence.
3.
+ * If the type name is not found, return InvalidOid if missing_ok
+ * = true, otherwise raise an error.
I can understand above comment, but I think it is better to improve it
by reffering other such instances. I like the explanation of missing_ok
in function header of relation_openrv_extended(). Could you please check
other places and improve this comment.
4. How is user going to distinguish between the cases when object-not-found
and more-than-one-object.
Do you think such a distinction is not required for user's of this API?
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | carriingfate92 | 2014-04-02 06:38:09 | Fwd: SSL auth question |
Previous Message | Andrew Dunstan | 2014-04-02 04:25:19 | Re: It seems no Windows buildfarm members are running find_typedefs |