| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Marti Raudsepp <marti(at)juffo(dot)org>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Golub <pavel(at)gf(dot)microolap(dot)com>, Pavel Golub <pavel(at)microolap(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pavel Stěhule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: Fwd: Proposal: variant of regclass |
| Date: | 2014-04-03 00:13:50 |
| Message-ID: | CA+TgmoY-O8yOcrrvCcWdkx9HGqWxPtUHwM4ry7bt3r-JHf=diw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 2, 2014 at 1:41 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Mon, Mar 31, 2014 at 7:08 PM, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
>> Hi Amit Kapila,
>>
>> Thank you for your reviewing. I updated the patch to v5.
>
> I have checked the latest version and found few minor improvements that
> are required:
>
> 1.
> ! if (!missing_ok)
> ! ereport(ERROR,
> ! (errcode(ERRCODE_UNDEFINED_OBJECT),
> ! errmsg("type \"%s\" does not exist",
> ! TypeNameToString(typeName)),
> ! parser_errposition(NULL, typeName->location)));
>
> pfree(buf.data); seems to be missing in error cases.
Eh, surely this is being done in some memory context that an error
will reset anyway?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Wim Lewis | 2014-04-03 00:32:51 | Re: Fwd: SSL auth question |
| Previous Message | Robert Haas | 2014-04-03 00:12:36 | Re: Fwd: SSL auth question |