Re: [bug fix] pg_ctl always uses the same event source

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: MauMau <maumau307(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_ctl always uses the same event source
Date: 2014-04-10 04:07:22
Message-ID: CAA4eK1KRKHtCQ1OAYuGMJx=hHy3i0qg=93jfwgLgkNq=KDRE6g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 7, 2014 at 7:10 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
>> On Sat, Apr 5, 2014 at 8:24 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> AFAICS, pg_ctl already reports to stderr if stderr is a tty. This whole
> issue only comes up when pg_ctl itself is running as a service (which
> I guess primarily means starting/stopping the postgresql service?).
> So that puts extra weight on trying to be sure that error messages go
> to a predictable place; the user's going to be hard-pressed to debug
> background failures without that.

Agreed. I think if this needs to fixed, then it will be better to do
as per your suggestion of adding a new switch. So I have marked this
patch as "Returned with feedback".

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomonari Katsumata 2014-04-10 04:19:28 small typo about comment in xlog.c
Previous Message Amit Kapila 2014-04-10 03:50:15 Re: four minor proposals for 9.5