Re: backup manifests

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: backup manifests
Date: 2020-03-24 03:43:04
Message-ID: CAA4eK1K+QUVkAEEm8Lhgea-y=QPqO7eKFQeywNqqdTcurpKF-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 23, 2020 at 9:46 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Mar 23, 2020 at 7:04 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > /src/bin/pg_validatebackup/tmp_check/t_002_algorithm_master_data/backup/none
> > --manifest-checksum none --no-sync
> > \tmp_install\bin\pg_basebackup.EXE: illegal option -- manifest-checksum
> >
> > It seems the option to be used should be --manifest-checksums. The
> > attached patch fixes this problem for me.
>
> OK, incorporated that.
>
> > > t/002_algorithm.pl ..... 4/19 # Failed test 'validate backup with
> > > algorithm "none"'
> > > # at t/002_algorithm.pl line 53.
> > >
> >
> > The error message for the above failure is:
> > pg_validatebackup: fatal: could not parse backup manifest: both
> > pathname and encoded pathname
> >
> > I don't know at this stage what could cause this? Any pointers?
>
> I think I forgot an initializer. Try this version.
>

All others except one are passing now. See the summary of the failed
test below and attached are failed run logs.

Test Summary Report
-------------------
t/003_corruption.pl (Wstat: 65280 Tests: 14 Failed: 0)
Non-zero exit status: 255
Parse errors: Bad plan. You planned 44 tests but ran 14.
Files=6, Tests=123, 164 wallclock secs ( 0.06 usr + 0.02 sys = 0.08 CPU)
Result: FAIL

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
003_corruption_master.log application/octet-stream 5.6 KB
regress_log_003_corruption application/octet-stream 6.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-03-24 03:44:38 Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Previous Message Michael Paquier 2020-03-24 03:22:16 Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line