| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Why conf.d should be default, and auto.conf and recovery.conf should be in it |
| Date: | 2014-01-17 05:07:13 |
| Message-ID: | CAA4eK1Jp+t6eEzDH1FYdqcnLpaZbu2q7Qk=EVWOLJghJv9TeeA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 17, 2014 at 12:16 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> PS: off topic, but isn't ParseConfigDirectory leaking the result
> of AbsoluteConfigLocation? In both normal and error paths?
Yes, I also think it leaks in both cases and similar leak is
present in ParseConfigFile(). I have tried to fix both of these
leaks with attached patch.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix_mem_leak_parse_config.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Chinner | 2014-01-17 05:40:08 | Re: [Lsf-pc] Linux kernel impact on PostgreSQL performance |
| Previous Message | Amit Kapila | 2014-01-17 03:46:50 | Re: Heavily modified big table bloat even in auto vacuum is running |