| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgresql.auto.conf and reload |
| Date: | 2014-08-07 03:36:04 |
| Message-ID: | CAA4eK1JJR7PG-wCN3mS9T9qPr=KbQquyML+SXKPmWBSN8x5cEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 6, 2014 at 1:32 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Tue, Jul 29, 2014 at 9:26 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> >
> > The reason is that during startup DataDir is not set by the time server
> > processes config file due to which we process .auto.conf file in second
> > pass. I think ideally it should ignore the invalid setting in such a
case
> > as it does during reload, however currently there is no good way to
> > process .auto.conf incase DataDir is not set, so we handle it
separately
> > in second pass.
>
> What about picking up only data_directory at the first pass?
I think that will workout and for that I think we might need to add
few checks during ProcessConfigFile. Do you want to address it
during parsing of config file or during setting of values?
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2014-08-07 04:26:24 | Re: pg_export_snapshot on standby side |
| Previous Message | Amit Kapila | 2014-08-07 03:28:51 | Re: postgresql.auto.conf and reload |