Re: [bug fix] pg_ctl fails with config-only directory

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: MauMau <maumau307(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_ctl fails with config-only directory
Date: 2013-12-08 04:22:39
Message-ID: CAA4eK1JHJvZL7r7jFDRx5qYOH6jNnEm0XvXA4Z09FVOd5U1Z6g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 7, 2013 at 6:02 PM, MauMau <maumau307(at)gmail(dot)com> wrote:
> From: "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>
>
>> Today, I had again gone through all the discussion that happened at
>> that time related to this problem
>> and I found that later in discussion it was discussed something on
>> lines as your Approach-2,
>> please see the link
>> http://www.postgresql.org/message-id/503A879C.6070703@dunslane.net
>
>
> Thank you again. I'm a bit relieved to see similar discussion.
>
>
>
>> Wouldn't the other way to resolve this problem be reinvoke pg_ctl in
>> non-restricted mode for the case in question?
>
>
> It's effectively the same as not checking admin privileges. And direct
> invocation of postgres -C/--describe-config still cannot be helped.

Yeah, that is the only point of reinvoke pg_ctl in non-restricted
mode, that it should be only allowed through
pg_ctl, but not directly with postgres -C.
In anycase, I think now we have link for the discussion and patch
as well for other Approach, so if the consensus
is to modify postgres code such that we don't need to check for
admin privs for -C/--describe-config option, then the
patch proposed by you can be taken else the other patch can be used.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2013-12-08 04:39:20 Re: Extra functionality to createuser
Previous Message MauMau 2013-12-08 02:41:12 Re: [bug fix] pg_ctl always uses the same event source