| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Few observations in replication slots related code |
| Date: | 2014-06-13 08:51:33 |
| Message-ID: | CAA4eK1JERi+P8L0jJ_3AJ1bJUNqa8RVekyUSBU510GqQW237pw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 13, 2014 at 1:45 PM, Andres Freund <andres(at)2ndquadrant(dot)com>
wrote:
> On 2014-06-13 13:01:59 +0530, Amit Kapila wrote:
> > Okay, but if it crashes before saving the persistency to permanent
> > file and there remains a .tmp for this replication slot which it created
> > during save of this persistency information, then also xmin will get
> > lost, because during startup it will not consider such a slot.
>
> I can't follow here. If it crashes before it's marked persistent it'll
> get deleted at startup (c.f. RestoreSlotFromDisk). And .tmp slots are
> cleaned up at restart.
Yes that's fine, the point I wanted to say here is that the flush
of slot in CreateInitDecodingContext() wouldn't save xmin in all
cases which is I think what it want to achieve.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-06-13 09:44:46 | Re: Few observations in replication slots related code |
| Previous Message | Abhijit Menon-Sen | 2014-06-13 08:40:12 | [PATCH] introduce XLogLockBlockRangeForCleanup() |