Re: patch to fix unused variable warning on windows build

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch to fix unused variable warning on windows build
Date: 2013-11-09 06:29:38
Message-ID: CAA4eK1+F+kNi+DqeGqJ_2y1FpTi-CVH4QyMC4ODDXWhOZ54nkw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 7, 2013 at 11:43 AM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> Attached is a small patch which fixes the unused variable warning in the
> visual studios build. Seems like VS does not support
> __attribute__((unused)) but looks like all other places we must assign to
> the variable.

I have raised same issue some time back, see the below link where
there is some discussion about it.
http://www.postgresql.org/message-id/CAA4eK1JEOa1hJGAUwPcqhw8av7zAPkDxJdwUbwEtjomi2f8hFg@mail.gmail.com

I think it is good, if one of committer's who have windows env. can
look into it and commit or provide suggestions, else you can make a
combined patch of this and other warning you saw on windows and upload
to next CF so that it doesn't get lost.
I checked that you have already submitted a patch for this warning
alone in CF.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2013-11-09 06:39:41 information schema parameter_default implementation
Previous Message David Rowley 2013-11-09 05:45:25 "Fix pg_isolation_regress to work outside its build directory" compiler warning