| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch: ALTER TABLE IF EXISTS |
| Date: | 2012-01-02 13:47:36 |
| Message-ID: | CA+U5nMLm5Opu8tK6v2CG1eb=NRicrGeK1Ah7wD3Z5twjWchibA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 2, 2012 at 1:11 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> this is relative simple patch that add possibility to skip noexisting
> tables. It is necessary for silent cleaning when dump is loaded.
Agreed, nice simple and uncontentious patch.
All good apart from two minor things:
* doc page needs to explain what IF EXISTS does, like DROP TABLE, e.g.
IF EXISTS
Do not throw an error if the table does not exist. A notice is
issued in this case.
* the error message is "does not exist" rather than "does not exists",
which means the code, a comment and a test need changing
Other than that, happy to apply as soon as you make those changes.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2012-01-02 13:59:24 | Re: patch: ALTER TABLE IF EXISTS |
| Previous Message | Pavel Stehule | 2012-01-02 13:11:58 | patch: ALTER TABLE IF EXISTS |