From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Bernd Helmle <mailings(at)oopsware(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Better support of exported snapshots with pg_dump |
Date: | 2014-11-17 22:13:55 |
Message-ID: | CA+U5nMLTmEO+CRHaxvgYTgKK22dh54GmMV94ASObVcq05m5sHA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 28 October 2014 11:34, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Oct 28, 2014 at 8:08 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>> Hi,
>>
>> On 28/10/14 03:15, Michael Paquier wrote:
>>>
>>>
>>> Updated patch with those comments addressed is attached.
>>
>>
>> Great, I have no further comments so I consider this patch ready for
>> committer (and will mark it so momentarily).
> OK thanks!
>
>> Just as a note - there is the issue you raised yourself about the less than
>> perfect error message, but I really don't think it's worth the trouble to
>> have special handling for it as the message coming from the server is clear
>> enough IMHO.
> Yeah thinking the same. Let's see what others think (btw, if this code
> gets committed, be sure to mark Simon as a co-author).
Committed.
Thanks very much for pushing forwards with this.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2014-11-17 22:58:37 | Re: proposal: plpgsql - Assert statement |
Previous Message | Simon Riggs | 2014-11-17 22:08:47 | Re: Turning off HOT/Cleanup sometimes |