Re: plpgsql.warn_shadow

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Florian Pflug <fgp(at)phlo(dot)org>
Subject: Re: plpgsql.warn_shadow
Date: 2014-03-18 20:59:59
Message-ID: CA+U5nMKja7VnNyfvLF-1KUEA03EKX4Ka7gDayfjEZaC5ThN-QA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 18 March 2014 20:52, Marti Raudsepp <marti(at)juffo(dot)org> wrote:
> On Tue, Mar 18, 2014 at 9:29 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>> Attached V4 uses "shadowed-variables" instead of "shadow".
>
> I think that should be "shadowed_variables" for consistency; GUC
> values usually have underscores, not dashes. (e.g.
> intervalstyle=sql_standard, backslash_quote=safe_encoding,
> synchronous_commit=remote_write etc)

Definitely. Sorry for not noticing that earlier; don't want dashes.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Tiikkaja 2014-03-18 21:10:42 Re: plpgsql.warn_shadow
Previous Message Andrew Dunstan 2014-03-18 20:57:04 Re: Wiki Page Draft for upcoming release