Re: Add shutdown_at_recovery_target option to recovery.conf

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Asif Naeem <anaeem(dot)it(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add shutdown_at_recovery_target option to recovery.conf
Date: 2014-11-20 09:37:33
Message-ID: CA+U5nMK-Y5Bd2riohBu=JOfO+OWssb89QadbGqP3JeP3AbfWAA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19 November 2014 22:47, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
> On 19/11/14 19:51, Simon Riggs wrote:
>>
>> On 19 November 2014 16:11, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>>
>>>> We need to be able to tell the difference between a crashed Startup
>>>> process and this usage.
>>>>
>>>> As long as we can tell, I don't mind how we do it.

...

> Ok this seems ok, I did couple of fixes - used exit code 3 as 2 is used in
> some places - given the "if (pid == StartupPID)" it would probably never
> conflict in practice, but better be safe than sorry in this case IMHO.
> And you forgot to actually set the postmaster into one of the Shutdown
> states so I added that.

Like it.

Patch looks good now. Will commit shortly.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Shulgin 2014-11-20 11:57:12 Re: [PATCH] add ssl_protocols configuration option
Previous Message Magnus Hagander 2014-11-20 09:26:37 Re: [PATCH] add ssl_protocols configuration option