Re: ALTER TABLE lock strength reduction patch is unsafe

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE lock strength reduction patch is unsafe
Date: 2014-03-03 16:22:55
Message-ID: CA+U5nMJYqDrL59rLVB08J0byy-PeZOaOX7h=4Av+MVQy-PdP5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3 March 2014 15:53, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> On 3 March 2014 15:19, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> What I'm
>>> really concerned about is whether there are other things like the
>>> SnapshotNow issues that can cause stuff to halt and catch fire. I
>>> don't know whether there are or are not, but that's my concern.
>
>> Of course its a concern, I feel it also. But that's why we have beta
>> period to handle the unknowns.
>
> I have exactly zero faith that beta testing would catch low-probability
> problems in this area. What's needed, and hasn't happened AFAIK, is
> detailed study of the patch by assorted senior hackers.
>
>> The question is are there any specific areas of concern here? If not,
>> then we commit because we've done a lot of work on it and at the
>> moment the balance is high benefit to users against a non-specific
>> feeling of risk.
>
> This is backwards. The default decision around here has never been
> to commit when in doubt.

I'm not in doubt.

If anybody can give me some more pointers of things to look at, I will.

But I've looked and I can't see anything more.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-03-03 16:26:52 Re: Changeset Extraction v7.9
Previous Message Robert Haas 2014-03-03 16:16:47 Re: GiST support for inet datatypes